Show the metadata tags in the flamegraph UI by default #91
+149
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## vc/tags #91 +/- ##
===========================================
- Coverage 96.60% 96.01% -0.60%
===========================================
Files 3 3
Lines 324 326 +2
===========================================
Hits 313 313
- Misses 11 13 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
NHDaly
force-pushed
the
nhd-tags-flamegraph
branch
from
c0399b8
to
c2ec74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to show the metadata tags in the flamegraph view, as root nodes, like this:
I don't love that the tags aren't labelled..... I've asked about that here:
google/pprof#811
I'm also not sure if
tagroot=is the right way to expose this. Maybe it should be higher-level, likemetadata::Booland we just add this? Orgroupby=["taskid", "threadid"], and we turn that into tagroots?